Add a --force option to the publish command #669
Conversation
This provides a simple way to ensure the published files are the latest available.
|
|
||
| /** | ||
| * The console command description. | ||
| * | ||
| * @var string | ||
| */ | ||
| protected $description = 'Publish the Laravel Sail Docker files'; | ||
| protected $description = 'Publish the Laravel Sail Docker files. If you want overwrite the existing files, you can add the `--force` option'; |
There was a problem hiding this comment.
No need for the extra explanation here.
| protected $description = 'Publish the Laravel Sail Docker files. If you want overwrite the existing files, you can add the `--force` option'; | |
| protected $description = 'Publish the Laravel Sail Docker files.'; |
There was a problem hiding this comment.
Hi @driesvints,
thanks for your suggestions.
Just for learning: is this really extra explanation? For me it was useful, because it's shown when php artisan is called.
| echo " ${GREEN}sail artisan sail:publish${NC} Publish the Sail configuration files" | ||
| echo " ${GREEN}sail build --no-cache${NC} Rebuild all of the Sail containers" | ||
| echo " ${GREEN}sail artisan sail:publish${NC} Publish the Sail configuration files" | ||
| echo " ${GREEN}sail artisan sail:publish --force${NC} Force publishing the Sail configuration (override existing files)" |
There was a problem hiding this comment.
| echo " ${GREEN}sail artisan sail:publish --force${NC} Force publishing the Sail configuration (override existing files)" | |
| echo " ${GREEN}sail artisan sail:publish --force${NC} Force publish the Sail configuration (overrides existing files)" |
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions! If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response. |
This provides a simple way to ensure the published files are the latest available.