[9.x] Overridable jobs #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Jun 1, 2021
|
Putting this in draft for now. Can you make the changes I requested? |
|
@driesvints Sure, thanks for the review and comment. It looks good now? |
driesvints
reviewed
Jun 1, 2021
driesvints
reviewed
Jun 1, 2021
driesvints
reviewed
Jun 1, 2021
|
If you fix the StyleCI warning and remove the two tests I highlighted I think we're good. |
|
@driesvints I didn't use StyleCI before. I need to register and configure an API key, right? Currently, the StyleCI website doesn't work for me so I can't do it locally. |
|
@driesvints Yes, the page doesn't work for me. Reported it to Graham on Twitter. |
driesvints
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the package's jobs open for extension, for users that want to adjust the
$tries,$backoff,$maxExceptionsproperties.I implemented the same approach that implemented on Laravel Sanctum, providing the user the freedom the choose which job class will be used in the config file.
Discussed in #474.