Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typesense] Issue when searching with queryCallback #817

Conversation

karakhanyans
Copy link
Contributor

No description provided.

@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

@driesvints
Copy link
Member

Hey @karakhanyans. Sorry, we usually require an explanation when doing PR's (see the PR template when submitting). Let's make sure next time we give Taylor all the info he needs to review a PR. I'll re-open this one for you and let Taylor know this is gtg.

@driesvints driesvints reopened this Apr 2, 2024
@karakhanyans
Copy link
Contributor Author

@driesvints Yes, sorry, as this was a bug fix, that's why I haven't written a detailed explanation.
Will do next time for sure.

@taylorotwell taylorotwell merged commit 3dde3c0 into laravel:10.x Apr 2, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when searching large datasets for common query using paginate
3 participants