Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fixes first class callables namespaces #39

Merged
merged 5 commits into from
Feb 11, 2022

Conversation

nunomaduro
Copy link
Member

This pull request fixes the serialisation of first class callable closures. As the full qualified namespaces were not being used on types.

Closes #38.

In other words:

// giving the code
namespace App\Models;
class User { function getUser(): User {} };

// and the serialisation of
$user->getUser(...);

// before 🛑
return function (): User {}

// after ✅
return function (): \App\Models\User {}

@taylorotwell taylorotwell merged commit 9e4b005 into master Feb 11, 2022
@taylorotwell taylorotwell deleted the fix/first-class-callables-namespaces branch February 11, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants