Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send appsecret_proof on FacebookProvider getUserByToken method. #100

Merged
merged 1 commit into from Aug 28, 2015

Conversation

elozoya
Copy link
Contributor

@elozoya elozoya commented Aug 28, 2015

This change makes better secured Server API calls.

There is a Facebook App setting named "Require App Secret".
When this setting is enabled every API call has to include a parameter called "appsecret_proof".
Facebook documentation recommends to enable this settings so that if a user's access token is stolen by a malicious software, every API call without an appsecret_proof will fail.

The app secret proof is a sha256 hash of your access token, using the app secret as the key. Here's what the call looks like in PHP:

$appsecret_proof= hash_hmac('sha256', $access_token, $app_secret); 

Facebook Docs

@taylorotwell
Copy link
Member

I need a description of what this actually does, etc.

@elozoya
Copy link
Contributor Author

elozoya commented Aug 28, 2015

I added a description.

@SammyK
Copy link
Contributor

SammyK commented Aug 28, 2015

👍 All good! :)

@taylorotwell taylorotwell merged commit f746424 into laravel:2.0 Aug 28, 2015
@elozoya
Copy link
Contributor Author

elozoya commented Aug 28, 2015

Yeaaah! my first pull request to an OpenSource project.
Thanks!

@SammyK
Copy link
Contributor

SammyK commented Aug 28, 2015

Congrats @emmanuellozoya! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants