Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapping Google Userinfo to User Object #316

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Fix mapping Google Userinfo to User Object #316

merged 1 commit into from
Dec 20, 2018

Conversation

joshbrown
Copy link
Contributor

It seems that Google's response when fetching the user info has changed.

Updated to reflect those changes. I could not find any change log on Google's side for reference.

#314 has some more info along with the specific error.

Google Returns the following for reference:

[
    "user" => [
        "id" => "",
        "email" => "",
        "verified_email" => "",
        "name" => "",
        "given_name" => "",
        "family_name" => "",
        "link" => "",
        "picture" => "",
        "locale" => ""
    ]
]

@rjvandoesburg
Copy link

You could do Arr::get($user, 'name', Arr::get($user, 'displayName')); so the old implementation won't break.

@driesvints
Copy link
Member

Looks like the fix from https://github.com/laravel/socialite/pull/283/files got reverted during a merge. Thanks for sending this in.

@rjvandoesburg don't think that's necessary as they key isn't present anymore.

@driesvints driesvints merged commit 73bbd8c into laravel:4.0 Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants