-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced deprecated app property in SocialiteManager #438
Replaced deprecated app property in SocialiteManager #438
Conversation
We'll need to convert the array access calls to |
I believe it does. According to the api docs. https://laravel.com/api/7.x/Illuminate/Container/Container.html |
also try this $relectionContainer = new ReflectionClass(get_class(app()));
dd($relectionContainer->getInterfaceNames()); And you will see 'ArrayAccess' in the list |
@ctwillie that's the implementation. The property references the contract which doesn't implements it (nor should it). |
@driesvints Aha! Something I'll keep in mind from here on out. Thanks. Will do a PR. |
@ctwillie those are not the docs for the container contract though. ;) https://laravel.com/api/7.x/Illuminate/Contracts/Container/Container.html |
@GrahamCampbell yea, I realize that now. I learned something new to pay attention to and stand corrected. Give me a break, I've only been coding for a couple of years, lol. Thanks for pointing that out though. |
Ok cool. Will do the same in master branch. |
…Manger class