Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpstan issues in Twitter and Slack drivers #653

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix phpstan issues in Twitter and Slack drivers #653

merged 1 commit into from
Aug 21, 2023

Conversation

alecpl
Copy link
Contributor

@alecpl alecpl commented Aug 21, 2023

This fixes an issue where phpstan throws: Access to an undefined property Laravel\Socialite\Contracts\User::$token on code like this:

$oauth_user = Socialite::driver($provider)->user();
$token = $oauth_user->token;

After the fix all OAuth2 drivers use the same implements ProviderInterface clause.

@taylorotwell taylorotwell merged commit 9989b45 into laravel:5.x Aug 21, 2023
20 checks passed
RealMrHex added a commit to RealMrHex/socialite that referenced this pull request Aug 23, 2023
@RealMrHex
Revert "Fix phpstan issues in Twitter and Slack drivers (laravel#653)"
91ca282 
This reverts commit 9989b45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alecpl @taylorotwell