Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issue with Google refreshToken() method #686

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

iBotPeaches
Copy link
Contributor

Fixes: #683


When issuing a refreshToken call with Google - you don't get a new refresh token. You are expected to keep the original one. At the moment Socialite makes an assumption that you will - thus crashes with:

Laravel\Socialite\Two\Token::__construct(): Argument 2 ($refreshToken) must be of type string, null given, called in vendor/laravel/socialite/src/Two/AbstractProvider.php on line 353.

Overrode refreshToken with specific implementation on Google, then added a test.

@taylorotwell taylorotwell merged commit d2a8113 into laravel:5.x Feb 8, 2024
22 checks passed
@driesvints driesvints changed the title Correct issue with Google refreshToken() method. Correct issue with Google refreshToken() method Feb 8, 2024
@iBotPeaches iBotPeaches deleted the google-refresh branch February 8, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refreshing access tokens does not work for Google
2 participants