Always register migrations #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we need to register migrations even if telescope is disabled so database would be ready when we switch state enable/disable. So there is no need to check and run migrations every time we enable telescope. It can be useful for CI/CD.
|
@MasterRO94 was this reverted ? it does not seems to be the case anymore edit: it seems, this is only on master and not on 4.x @taylorotwell there is 2 years old commits on master that never went live on 4.x, and as far as i can tell, there is no 5.x planned perhaps it's worth reviewing them, and including the usefull ones in the 4.x like this pr thanks. |
|
Yes, we use my PR patch via composer patches plugin https://github.com/cweagans/composer-patches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we need to register migrations even if telescope is disabled so database would be ready when we switch state enable/disable. So there is no need to check and run migrations every time we enable telescope. It can be useful for CI/CD.