QueryWatcher location can ignore Composer packages #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmd
changed the title
derekmd
changed the title
|
Why not just ignore all paths that start with |
|
I amended the pull request to not require naming the packages: Watchers\QueryWatcher::class => [
'enabled' => env('TELESCOPE_QUERY_WATCHER', true),
'ignore_packages' => true,
'slow' => 100,
], |
For query "Location" shown in the UI, allow ignoring Composer packages other than laravel/* so the class/line number from your app code will be shown instead. This would cover 3rd-party query builder packages such as: * spatie/laravel-translatable * dimsav/laravel-translatable * staudenmeir/eloquent-eager-limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Eloquent models use third-party Composer packages to build queries, the query watcher can log class / line number location for a file outside of the Laravel
app/orresources/viewssubdirectories.Example Composer packages:
Find query location in your application code
Example configuration:Changed in a comment below to['ignore_packages' => true].In addition to ignoring
vendor/laravel/*, this will also ignorevendor/dimsav/laravel-translatablefile paths (orvendor\dimsav\laravel-translatableon Windows) and go further up the callee stacktrace to find where the query was started.PHPUnit Coverage
This is difficult to test in PHPUnit since
getCallerFromStackTrace()calls PHP functiondebug_backtrace()that can't be overloaded.I confirmed this works as intended for two Laravel codebases affected by this.