Optimize dump #683
Optimize dump #683
Conversation
|
Are there breaking changes here? If not then shouldn't this be sent to 2.0 branch instead? |
|
To be honest, I'm not really sure which branch is correct. I saw the latest development happen in the master branch, and as far as I can tell, none of them are breaking changes. So not sure why this branch is 3.0 instead of 2.1, or why there is a seperate branch. Looking at it now, they are only fixes / small changes: https://github.com/laravel/telescope/compare/master |
|
@barryvdh 3.0 hasn't been released yet. All our repos follow the same branching system where the master is always the next major version. Backwards compatible new features can always be sent to the current release branch: https://laravel.com/docs/5.8/contributions#which-branch |
|
Okay, then I think you can merge all commits from master into 2.0 and I'll update my open PR's to 2.0 after that. |
|
@barryvdh I got a bit stuck with cherry-picking so feel free to backport yourself if you want this in the next 2.x release. |
|
Okay, which one do you not want to include on 2.0? Looking through the commits, the only one that might be unneccesary is your dev-master update, but that doesn't matter on branches that are not dev-master, right? |
|
@barryvdh I wanted to backport but the cherry-picking just failed for me. So didn't want to lose too much time on this. Just feel free to send this in yourself. |
|
@driesvints so #686 ? |
This shuld fix #682 and partially fix #611 (or at least give the user some information about it).
Addition could be to specify a cache driver in config/telescope, so that the Telescope driver could be different (eg. if you want to work with the array driver locally).
This shows an error when something goes wrong (eg. the wrong cache driver in this instance).
It also changes the loading of entries to check 1 entry and only load the rest when something changed (just like the rest of the Index screens).