Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent resuming recording when processing sync job #720

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Prevent resuming recording when processing sync job #720

merged 2 commits into from
Sep 5, 2019

Conversation

erikgaal
Copy link
Contributor

@erikgaal erikgaal commented Sep 4, 2019

This PR attempts to resolve the bug report made in #719.

The storeIfDoneProcessingJob method already contained a condition for checking if $connectionName !== 'sync', so it seemed reasonable that this condition was also checked when starting recording.

if (empty(static::$processingJobs) && $event->connectionName !== 'sync') {
static::store($app[EntriesRepository::class]);
static::stopRecording();
}

This fixed the regression test that I added.

@taylorotwell taylorotwell merged commit d65cf82 into laravel:2.0 Sep 5, 2019
@erikgaal erikgaal deleted the patch-dont-resume-recording-with-sync-jobs branch September 5, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants