Fixed missing validation error for password #225
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user tries to login and enters the wrong password, the authentication fails and the
sendFailedLoginResponse
is triggered. Previously this function only throws aValidationException
with theemail
field, causing the error message ofauth.failed
which in default Laravel app is "These credentials do not match our records." to only appear below the email input field, and does not show any invalidity in the UI in the password field, even if the password field is what was incorrect (I observed this when using Bootstrap scaffolding). As a result this would make the user feel that the incorrect input was the email address rather than the password.This PR is an attempt to fix this issue by adding the
password
field to theValidationException
. By doing this, the error bag contains thepassword
field and appropriate invalid message and UI elements are shown.Tests are edited accordingly.