Allow using login for API routes without session #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful to use the same `AuthenticatesUsers` trait for login via API as for login in the browser, because the trait provides things like throttling and validation. The problem is similar to the discussion in laravel#208 - API routes may not have a session. This PR adds `if ($request->hasSession()) {` the same as the comments in laravel#208 suggest. This also replaces laravel#90 properly.
|
I would suggest just changing the code in your own application if you need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to use the same
AuthenticatesUserstrait for login via API as for login in the browser, because the trait provides things like throttling and validation.The problem is similar to the discussion in #208 - API routes may not have a session.
This PR adds
if ($request->hasSession()) {the same as the comments in #208 suggest.This also replaces #90 properly.