Change extension of React component #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see this was already merged, but figured I'd add my $0.02 anyways. Using the The React team has recommended against using the |
|
Yep, I think .jsx extension shouldn't be used at all. Full explanation by Dan here: airbnb/javascript#985 (comment) By the amount of upvotes on that comment, I assume that it's also how most of react community feels |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the extension of the example React component from .js to .jsx (which will help IDEs and editors to highlight the JSX template).
Tested the change locally in a new Laravel project and it still compiles successfully with Mix.