This repository has been archived by the owner on May 20, 2024. It is now read-only.
Fix timestamps #18
Closed
Fix timestamps #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moment.js library is already using the correct timezone, so adding this generates and increment on the starting time.
Unless laravel timezone was UTC, this was generating an incorrect moment object.
One line fix
|
Thanks for contributing. This issue has been addressed: 3d7d269. The release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moment.js library is already initializing detecting user timezone (UTC-5 in my case). So, setting
moment.tz.setDefault(App.timezone);using laravel config timezone, alters the default moment() object and produces an object with the time displaced twice. Calculating the timezone diff and adding it to the startTime value was causing and infinite increment every time the component loads.I tested this in a brand new laravel 8 installation, and worked ok, detecting my timezone.