[0.8.x] Custom PageNotFoundError for resolvePageComponent #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a generic
Error
is thrown inresolvePageComponent
, this PR changes that to aPageNotFoundError
. This is particularly useful for projects that use React and want to transition from JS to TS. With this change it would be easier to load components from different locations/paths, or different file types such asjsx
andtsx
. With the custom exception it's a lot easier to check if the component doesn't exist or if it's another kind of error. An example in Inertia might look something like this: