Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate BrowserKit tests to HTTP tests #984

Merged
merged 18 commits into from
Mar 12, 2024
Merged

Migrate BrowserKit tests to HTTP tests #984

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
613f682
migrate AdminTest from browserkit tests to http tests
fabiorodriguesroque Dec 28, 2023
0b421b4
update assertRedirectToRoute() by assertRedirect()
fabiorodriguesroque Dec 29, 2023
376e869
remove BrowserKit from AdminTest
fabiorodriguesroque Dec 29, 2023
e7f14b2
update ArticleTest
fabiorodriguesroque Dec 29, 2023
3bb0015
update BlockUsersTest
fabiorodriguesroque Dec 29, 2023
43f389d
update CanonicalUrlTest
fabiorodriguesroque Dec 29, 2023
a6869b8
update HomeTest
fabiorodriguesroque Dec 31, 2023
f379758
update ModeratorTest
fabiorodriguesroque Dec 31, 2023
5eb7e0d
update NavigationTest
fabiorodriguesroque Dec 31, 2023
5b3fada
update NotificationsTest
fabiorodriguesroque Dec 31, 2023
0ca9980
update ProfileTest
fabiorodriguesroque Dec 31, 2023
65125d0
update ReplyTest
fabiorodriguesroque Dec 31, 2023
0fab4e9
migrate settingsTest
fabiorodriguesroque Jan 13, 2024
40b24f6
update AuthTest
fabiorodriguesroque Jan 15, 2024
11ff631
remove RouteServiceProvider from authtest
fabiorodriguesroque Jan 15, 2024
0840d38
update ForumTest
fabiorodriguesroque Feb 14, 2024
258ea0a
fix: two failed forum tests
fabiorodriguesroque Mar 6, 2024
2bad584
build: remove browser kit testing depedency
fabiorodriguesroque Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions tests/Feature/AdminTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
use App\Models\User;
use Carbon\Carbon;
use Illuminate\Foundation\Testing\DatabaseMigrations;
use Tests\Feature\BrowserKitTestCase;
use Tests\TestCase;

uses(BrowserKitTestCase::class);
uses(TestCase::class);
uses(DatabaseMigrations::class);

test('requires login', function () {
$this->visit('/admin')
->seePageIs('/login');
$this->get('/admin')
->assertRedirect('/login');
});

test('normal users cannot visit the admin section', function () {
Expand Down Expand Up @@ -83,9 +83,9 @@
$this->loginAsAdmin();

$this->put('/admin/users/'.$user->username().'/ban')
->assertRedirectedTo('/');
->assertRedirect('/');

test()->seeInDatabase('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
test()->assertDatabaseHas('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
});

test('moderators cannot ban a user without a reason', function () {
Expand All @@ -94,9 +94,9 @@
$this->loginAsModerator();

$this->put('/admin/users/'.$user->username().'/ban')
->assertRedirectedTo('/');
->assertRedirect('/');

test()->seeInDatabase('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
test()->assertDatabaseHas('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
});

test('admins can delete a user', function () {
Expand All @@ -108,14 +108,14 @@
$this->loginAsAdmin();

$this->delete('/admin/users/'.$user->username())
->assertRedirectedTo('/admin/users');
->assertRedirect('/admin/users');

$this->notSeeInDatabase('users', ['name' => 'Freek Murze']);
$this->assertDatabaseMissing('users', ['name' => 'Freek Murze']);

// Make sure associated content is deleted.
$this->notSeeInDatabase('threads', ['author_id' => $user->id()]);
$this->notSeeInDatabase('replies', ['replyable_id' => $thread->id()]);
$this->notSeeInDatabase('replies', ['author_id' => $user->id()]);
$this->assertDatabaseMissing('threads', ['author_id' => $user->id()]);
$this->assertDatabaseMissing('replies', ['replyable_id' => $thread->id()]);
$this->assertDatabaseMissing('replies', ['author_id' => $user->id()]);
});

test('admins cannot delete other admins', function () {
Expand Down Expand Up @@ -144,9 +144,9 @@
$this->loginAsAdmin();

$this->get('admin')
->see($submittedArticle->title())
->dontSee($draftArticle->title())
->dontSee($liveArticle->title());
->assertSee($submittedArticle->title())
->assertDontSee($draftArticle->title())
->assertDontSee($liveArticle->title());
});

test('moderators can list submitted articles', function () {
Expand All @@ -157,9 +157,9 @@
$this->loginAsModerator();

$this->get('admin')
->see($submittedArticle->title())
->dontSee($draftArticle->title())
->dontSee($liveArticle->title());
->assertSee($submittedArticle->title())
->assertDontSee($draftArticle->title())
->assertDontSee($liveArticle->title());
});

test('users cannot list submitted articles', function () {
Expand All @@ -171,7 +171,7 @@

test('guests cannot list submitted articles', function () {
$this->get('admin')
->assertRedirectedTo('login');
->assertRedirect('/login');
});

test('admins can view submitted articles', function () {
Expand All @@ -180,7 +180,7 @@
$this->loginAsAdmin();

$this->get("articles/{$article->slug()}")
->see('Awaiting Approval');
->assertSee('Awaiting Approval');
});

test('admins can approve articles', function () {
Expand Down Expand Up @@ -216,7 +216,7 @@
$article = Article::factory()->create(['submitted_at' => now()]);

$this->put("/admin/articles/{$article->slug()}/approve")
->assertRedirectedTo('/login');
->assertRedirect('/login');

expect($article->fresh()->approvedAt())->toBeNull();
});
Expand Down Expand Up @@ -254,7 +254,7 @@
$article = Article::factory()->create(['submitted_at' => now(), 'approved_at' => now()]);

$this->put("/admin/articles/{$article->slug()}/disapprove")
->assertRedirectedTo('/login');
->assertRedirect('/login');

$this->assertNotNull($article->fresh()->approvedAt());
});
Expand Down Expand Up @@ -357,30 +357,30 @@ function assertCanSeeTheUserOverview()
User::factory()->create(['name' => 'Freek Murze']);
User::factory()->create(['name' => 'Frederick Vanbrabant']);

test()->visit('/admin/users')
->see('Freek Murze')
->see('Frederick Vanbrabant');
test()->get('/admin/users')
->assertSee('Freek Murze')
->assertSee('Frederick Vanbrabant');
}

function assertCanBanUsers()
{
$user = User::factory()->create(['name' => 'Freek Murze']);

test()->put('/admin/users/'.$user->username().'/ban', ['reason' => 'A good reason'])
->assertRedirectedTo('/user/'.$user->username());
->assertRedirect('/user/'.$user->username());

test()->notSeeInDatabase('users', ['id' => $user->id(), 'banned_at' => null]);
test()->seeInDatabase('users', ['id' => $user->id(), 'banned_reason' => 'A good reason']);
test()->assertDatabaseMissing('users', ['id' => $user->id(), 'banned_at' => null]);
test()->assertDatabaseHas('users', ['id' => $user->id(), 'banned_reason' => 'A good reason']);
}

function assertCanUnbanUsers()
{
$user = User::factory()->create(['name' => 'Freek Murze', 'banned_at' => Carbon::now()]);

test()->put('/admin/users/'.$user->username().'/unban')
->assertRedirectedTo('/user/'.$user->username());
->assertRedirect('/user/'.$user->username());

test()->seeInDatabase('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
test()->assertDatabaseHas('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
}

function assertCannotBanAdmins()
Expand Down
Loading
Loading