Skip to content
This repository has been archived by the owner on Sep 11, 2021. It is now read-only.

Conversation

NicklasWallgren
Copy link

No description provided.

@mabasic
Copy link
Member

mabasic commented Apr 27, 2020

Why do we need a config_path function in this package?

@NicklasWallgren
Copy link
Author

NicklasWallgren commented Apr 27, 2020

It's a pretty commonly used method in service providers, and lumen doesn't include this method and therefore a few libs won't work out-of-the-box while running vendor:publish.

For example https://github.com/avto-dev/roadrunner-laravel/blob/master/src/ServiceProvider.php.

Others has encountered this issue before me.
#5

@mabasic
Copy link
Member

mabasic commented Apr 27, 2020

I see. Thank you for explaining. It would make sense to include this helper function considering what this package does, but to keep this package simple (being a direct copy) and prevent adding bloat I don't want to add this now.

When the user (Developer) is faced with this error complaining about missing config_path function, it is always possible to add one themselves in their application. Some people don't need it and it would pollute their global functions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants