wip

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

.gitattributes

@@ -8,6 +8,7 @@
 /.gitignore export-ignore
 /.php_cs export-ignore
 /.travis.yml export-ignore
+/phpstan-baseline.neon export-ignore
 /phpstan.neon.dist export-ignore
 /phpunit.xml export-ignore
 /LICENSE export-ignore

phpstan-baseline.neon

@@ -0,0 +1,7 @@
+parameters:
+	ignoreErrors:
+		-
+			message: "#^Cannot use array destructuring on Illuminate\\\\Support\\\\Collection\\<\\(int\\|string\\), mixed\\>&iterable\\<Illuminate\\\\Support\\\\Collection\\<\\(int\\|string\\), mixed\\>\\>\\.$#"
+			count: 1
+			path: src/Searchable.php
+

phpstan.neon.dist

@@ -1,5 +1,6 @@
 includes:
   - ./vendor/nunomaduro/larastan/extension.neon
+  - ./phpstan-baseline.neon
 
 parameters:
 

src/Column.php

@@ -65,7 +65,7 @@ public function getOriginalValue()
      */
     public function getValue(): string
     {
-        if (is_string($this->name)) {
+        if (\is_string($this->name)) {
             return $this->name;
         }
 

src/Field.php

@@ -76,15 +76,15 @@ protected function validateJsonPath(): bool
      */
     public function isRelationSelector(): bool
     {
-        return strpos($this->name ?? '', '.') !== false;
+        return strpos($this->name, '.') !== false;
     }
 
     /**
      * Is JSON path selector.
      */
     public function isJsonPathSelector(): bool
     {
-        return strpos($this->name ?? '', '->') !== false;
+        return strpos($this->name, '->') !== false;
     }
 
     /**

src/Keyword.php

@@ -116,7 +116,7 @@ public static function searchable(
         }
 
         return [
-            str_replace($wildcard ?? '*', $replacement ?? '%', $text),
+            str_replace($wildcard ?? '*', $replacement, $text),
         ];
     }
 

src/Searchable.php

@@ -65,6 +65,10 @@ public function apply($query)
 
         $likeOperator = like_operator(connection_type($query));
 
+        /**
+         * @var \Illuminate\Support\Collection $filters
+         * @var \Illuminate\Support\Collection $fields
+         */
         [$filters, $fields] = Collection::make($this->fields)->partition(static function ($field) {
             return $field instanceof Contracts\Filter\Filter;
         });