Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data 2022 #94

Closed
wants to merge 1 commit into from
Closed

data 2022 #94

wants to merge 1 commit into from

Conversation

ramaID
Copy link
Member

@ramaID ramaID commented Aug 29, 2022

@ramaID ramaID requested a review from uyab August 29, 2022 16:49
@uyab
Copy link
Contributor

uyab commented Aug 30, 2022

Ini beberapa cuma beda case (UPPERCASE vs Title Case). Yang seperti itu bisa diskip dulu kah? Biar enak lihat diffnya, data apa yang nambah/berubah/dihapus.

@ramaID
Copy link
Member Author

ramaID commented Aug 30, 2022

hmm, okay Pak @uyab nanti ku coba urutin sesuai dengan data sebelumnya

@lakuapik
Copy link
Contributor

lakuapik commented Sep 8, 2022

Ini beberapa cuma beda case (UPPERCASE vs Title Case). Yang seperti itu bisa diskip dulu kah? Biar enak lihat diffnya, data apa yang nambah/berubah/dihapus.

#ask nantinya, yang title case akankah juga akan di merge pak @uyab ?

@uyab
Copy link
Contributor

uyab commented Sep 8, 2022

@lakuapik ini pertanyaan susah ternyata, gimana cara validasinya ya? Secara format lebih enak dilihat Title Case. Tapi ekspektasinya, dari diff commit bisa kelihatan data apa yang (riil) berubah, ga sekedar ganti format aja.

@lakuapik
Copy link
Contributor

lakuapik commented Sep 8, 2022

@uyab harusnya di split 2 PR kali ya biar diffnya beda? 1 untuk yang perubahan data, 1 yang title case.

tapi gak tahu tuh gimana caranya ngeparsing mana yang berubah datanya, bukan title casenya.

@lakuapik
Copy link
Contributor

pak @uyab, ada rencana akan merging ini?

@ramaID ramaID mentioned this pull request Dec 31, 2022
@ramaID
Copy link
Member Author

ramaID commented Dec 31, 2022

ku close yang ini, karena berantakan.

next, akan ada PR untuk data desa.

berdasarkan counting sederhana, harusnya ke depan ada 26 data desa baru.

Screenshot 2022-12-31 at 13 12 20

@ramaID ramaID closed this Dec 31, 2022
@uyab
Copy link
Contributor

uyab commented Jan 2, 2023

Thank you @ramaID for your contributions. Awesome as usual 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants