Fixed issue #3 (infinite recursion in grammar)

lark-parser · Mar 9, 2017 · 24f8656 · 24f8656
1 parent d40ddff
commit 24f8656
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lark/parsers/earley.py b/lark/parsers/earley.py
@@ -105,6 +105,8 @@ def add(self, items):
                         new_tree = old_tree.copy()
                         new_tree.rule = old_tree.rule
                         old_tree.set('ambig', [new_tree])
+                    if item.tree.children[0] is old_tree:   # XXX a little hacky!
+                        raise ParseError("Infinite recursion in grammar!")
                     old_tree.children.append(item.tree)
                 else:
                     self.completed[item] = item

diff --git a/tests/test_parser.py b/tests/test_parser.py
@@ -39,6 +39,16 @@ def test_same_ast(self):
         l2 = g.parse('(a,b,c,*x)')
         assert l == l2, '%s != %s' % (l.pretty(), l2.pretty())
 
+    def test_infinite_recurse(self):
+        g = """start: a
+               a: a | "a"
+            """
+
+        self.assertRaises(GrammarError, Lark, g, parser='lalr')
+
+        l = Lark(g, parser='earley')
+        self.assertRaises(ParseError, l.parse, 'a')
+
 
 class TestEarley(unittest.TestCase):
     def test_anon_in_scanless(self):