Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confusing import in examples #1138

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Fix confusing import in examples #1138

merged 1 commit into from
Apr 23, 2022

Conversation

JonasLoos
Copy link
Contributor

Somehow extend_python.py imported PythonIndenter not from lark.indenter, but from python_parser.py, which then imported it from lark.indenter. As far as I see, this doesn't make any sense.

This PR changes extend_python.py to directly import from lark.indenter and doesn't change any functionality (as far as I understand).

MegaIng
MegaIng approved these changes Apr 23, 2022
View reviewed changes
Copy link
Member

@MegaIng MegaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this is historic. PythonIndenter wasn't always in lark.indenter

@erezsh erezsh merged commit e5a8669 into lark-parser:master Apr 23, 2022
@JonasLoos
Copy link
Contributor Author

The reason for this is historic. PythonIndenter wasn't always in lark.indenter

Ah ok, makes sense.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaIng MegaIng MegaIng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonasLoos @MegaIng @erezsh