Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added strict-mode, enabled using the strict=True flag #1261

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

erezsh
Copy link
Member

@erezsh erezsh commented Mar 9, 2023

No description provided.

@erezsh erezsh requested a review from MegaIng March 9, 2023 10:34
Copy link
Member

@MegaIng MegaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few more tests might be nice.

For a future PR, it might be nice to transform LarkOptions and the two Config classes into dataclasses. Would remove some code duplication

@erezsh
Copy link
Member Author

erezsh commented Mar 9, 2023

Definitely, I'm going to add some tests.

Sure, I'm pro dataclasses. But they have to be backported for Python 3.6.

@MegaIng
Copy link
Member

MegaIng commented Mar 9, 2023

There is such a backport, I am using it in interegular.

@erezsh
Copy link
Member Author

erezsh commented Mar 9, 2023

Yes, I know. That's why I said I'm okay with it.

@erezsh erezsh merged commit a9d353e into master Mar 9, 2023
@MegaIng
Copy link
Member

MegaIng commented Mar 9, 2023

This mode should probably be recommended in the how_to_use file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants