Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added progress bar recipe #1267

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Added progress bar recipe #1267

merged 2 commits into from
Mar 16, 2023

Conversation

MegaIng
Copy link
Member

@MegaIng MegaIng commented Mar 16, 2023

As suggested on gitter.

@erezsh
Copy link
Member

erezsh commented Mar 16, 2023

Looking good! Just one thing, I think we should emphasize that this only works for LALR. Right now, it might seem like it works for both parsers.

@MegaIng
Copy link
Member Author

MegaIng commented Mar 16, 2023

Aha true.

@erezsh erezsh merged commit 2de51ce into lark-parser:master Mar 16, 2023
@MegaIng MegaIng deleted the tqdm-recipe branch March 16, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezsh erezsh erezsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MegaIng @erezsh