Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin manager support #87

Open
audunmo opened this issue Aug 19, 2020 · 2 comments
Open

Plugin manager support #87

audunmo opened this issue Aug 19, 2020 · 2 comments

Comments

@audunmo
Copy link

audunmo commented Aug 19, 2020

I'd love to add zplug support and other plugin manager support to this. Is this something that PRs would be welcomed for?

@xkortex
Copy link

xkortex commented Aug 21, 2020

I just did a test run on this for oh-my-zsh (never tried zplug but I imagine it's similar?). Instead of

    autoload -Uz add-zsh-hook

in .zshrc, I have plugins=(git zsh-autosuggestions ...others... zsh-histdb). Then, to match the oh-my-zsh plugin pattern ( '$base_dir/plugins/$name/$name.plugin.zsh' or '$base_dir/plugins/$name/_$name'), I just symlinked ln -s sqlite-history.zsh zsh-histdb.plugin.zsh.

Seems to work just the same. So that is a plausible addition. In fact $name.plugin.zsh seems a quite common pattern. I wonder if it's worth it to rename sqlite-history.zsh to zsh-histdb.plugin.zsh.

@larkery
Copy link
Owner

larkery commented Jan 14, 2021

I don't use any of these things, but I thought I had accepted a PR which did this already?

My impression was that the existence of this file: https://github.com/larkery/zsh-histdb/blob/master/zsh-histdb.plugin.zsh

would do the job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants