redirect reply.translation to be updated via pub/sub #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianamarasoiu
approved these changes
Feb 13, 2020
danrubel
force-pushed
the
dan-pubsub-reply-translation
branch
from
b347911
to
0fefc0d
Compare
danrubel
changed the base branch from
dan-refactor-save-text-action
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the prior refactor save text action PR so that reply.translation changes are consolidated over a rolling 3 second period and updated via pub/sub rather than directly modifying firebase.
In addition, 2 unused
Messagemethods were removed.cc @lukechurch