.is_selector_registered()
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddsjoberg
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
@larmarange looks great! thank you so much for putting it together!
I updated the function name from registered to scoped to more accurately reflect what is going on.
PS Apologies for being quiet on the workflows/tidymodels issues. I am swamped at work, but taking two weeks after starting next week! Should be able to return to them after vacation.
|
@ddsjoberg Thanks PS: no worry about tidymodels, there is no emergency. Enjoy your vacation. |
|
Quick question: why two dots in the function name? |
Oops, a bad copy+paste mistake! i just updated and pushed |
Codecov Report
@@ Coverage Diff @@
## main #164 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 38 38
Lines 1605 1605
=======================================
Hits 1591 1591
Misses 14 14
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #163