Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy_select_variables() now sorts the variables according to include #184

Merged
merged 5 commits into from Oct 8, 2022

Conversation

larmarange
Copy link
Owner

Fix #183

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #184 (534fa80) into main (70fcaa9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files          38       38           
  Lines        1695     1700    +5     
=======================================
+ Hits         1673     1678    +5     
  Misses         22       22           
Impacted Files Coverage Δ
R/tidy_select_variables.R 100.00% <100.00%> (ø)

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great and it consistent with other selectors too!

@larmarange larmarange merged commit 6a5f6be into main Oct 8, 2022
@larmarange larmarange deleted the issue183 branch October 8, 2022 09:37
@larmarange
Copy link
Owner Author

Thanks, it is merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should tidy_select_variables() rearrange the order of the variables according to include?
2 participants