Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python version requirements #74

Closed
skoslowski opened this issue Apr 24, 2020 · 4 comments
Closed

Python version requirements #74

skoslowski opened this issue Apr 24, 2020 · 4 comments

Comments

@skoslowski
Copy link

skoslowski commented Apr 24, 2020

I am (happily) using utt 1.22 with Python 3.7. It mostly works perfectly, however utt report --week fails with an

AttributeError: type object 'datetime.date' has no attribute 'fromisocalendar'

This function was added in Python 3.8.

Not sure if this is a mistake or if Python 3.8 is intended to be the minimum required version, in which case may I suggest to add a python_requires setting to setup() and update Pipfile

Thanks for putting this package together!

@larose
Copy link
Owner

larose commented Apr 24, 2020

Thanks for the bug report @skoslowski. That's indeed a mistake, the intent is to support Python 3.7. I'll check how to backport that feature to Python 3.7 and make a new release. I should be able to do this in the next few weeks.

@ukrutt
Copy link
Contributor

ukrutt commented May 5, 2020

Sorry for the delay.

I believe I'm the one who originally added this feature. It relies on some functions in fromisocalendar, which was added in 3.8. I tried to do it without fromisocalendar, but that would have necessitated a lot of machinery -- and at the time I did not see the point of reinventing the wheel.

Thus, the --week switch, for now, is only available if you run Python 3.8.

larose added a commit that referenced this issue May 9, 2020
larose added a commit that referenced this issue May 9, 2020
@larose
Copy link
Owner

larose commented May 9, 2020

This has been fixed in 1.23!

@larose larose closed this as completed May 9, 2020
@ukrutt
Copy link
Contributor

ukrutt commented May 11, 2020

Thanks @larose !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants