Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a more generic link domain #39

Open
larowlan opened this issue May 9, 2015 · 4 comments
Open

Consider a more generic link domain #39

larowlan opened this issue May 9, 2015 · 4 comments

Comments

@larowlan
Copy link
Owner

larowlan commented May 9, 2015

Now that https://www.drupal.org/node/2336247 is in we can use a more generic link domain, i.e instead of http://drupal.org/x/y/z URIs we could use default-content:x/y/z

However this will break existing exports so it would be an API change.

Thoughts?

@benjy
Copy link
Collaborator

benjy commented May 9, 2015

It's an easy fix though right? A simple find and replace in the export.

@jibran
Copy link
Collaborator

jibran commented May 9, 2015

What about already imported content? Do we need a migration for that?

@andypost
Copy link
Collaborator

andypost commented May 9, 2015

maybe it's time to implement hook_update?

@larowlan
Copy link
Owner Author

larowlan commented May 9, 2015

It won't change imported content, only existing exports and @benjy is
right, find and replace would suffice
On 10 May 2015 4:53 am, "Andy Postnikov" notifications@github.com wrote:

maybe it's time to implement hook_update?


Reply to this email directly or view it on GitHub
#39 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants