Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add QuickNet API links #240

Closed
wants to merge 2 commits into from
Closed

add QuickNet API links #240

wants to merge 2 commits into from

Conversation

koenhelwegen
Copy link
Contributor

To be merged after larq/docs#20.

@koenhelwegen koenhelwegen added the skip-changelog Don't mention this change in the changelog label Mar 3, 2020
@koenhelwegen koenhelwegen marked this pull request as ready for review March 4, 2020 11:08
@koenhelwegen koenhelwegen requested a review from a team March 4, 2020 11:08
Copy link
Member

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this version of QuickNet uses GlobalAveragePooling at the end which we saw might be slower than an equivalent average-pool and reshape (see tensorflow/tensorflow#29443).

@koenhelwegen Would this change the benchmarking results?

@koenhelwegen
Copy link
Contributor Author

Well spotted! Looks like we made the replacement in the h5 files but not in the architecture implementation in zoo. We should correct that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Don't mention this change in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants