Add grouped binary convolution support (2/3): reference kernel. #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2020
AdamHillier
commented
Oct 22, 2020
Tombana
approved these changes
Oct 23, 2020
AdamHillier
force-pushed
the
grouped-convolutions-converter
branch
2 times, most recently
from
1392f3e
to
1ba74aa
Compare
AdamHillier
force-pushed
the
grouped-convolutions-reference
branch
from
9f32b05
to
1fe65da
Compare
This was referenced Nov 5, 2020
Add support for grouped binary convolutions to the reference kernel. Extend the kernel tests to include grouped convolutions, through emulation with multiple convolutions since the built-in Conv2D op doesn't support groups.
AdamHillier
force-pushed
the
grouped-convolutions-reference
branch
from
1fe65da
to
b15e227
Compare
Tombana
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is second of a group of PRs to add support for grouped binary convolutions. I've split the work into three PRs to make review easier.
This PR adds support for grouped convolutions to the reference kernel.
How Has This Been Tested?
The kernel tests have been extended to include grouped convolution test cases. This was more complicated than it seems, because the built-in Conv2D op doesn't support groups. To calculate the expected output, I therefore emulate a grouped convolution with multiple Conv2D ops and manual concatenation at the end.
Benchmark Results
N/A.
Related issue number
#549, #551.