Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix twitter link and minify generated html pages to save a few kB #116

Merged
merged 2 commits into from Jul 2, 2019
Merged

Fix twitter link and minify generated html pages to save a few kB #116

merged 2 commits into from Jul 2, 2019

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Jul 1, 2019

No description provided.

@lgeiger lgeiger added the documentation Issues related to missing or wrong documentation label Jul 1, 2019
@jamescook106
Copy link
Contributor

@lgeiger do you want me to carry on adding commits to this or review it? As it is assigned rather then being requested as a reviewer?

@lgeiger
Copy link
Member Author

lgeiger commented Jul 2, 2019

@lgeiger do you want me to carry on adding commits to this or review it? As it is assigned rather then being requested as a reviewer?

Sorry, I meant to assign you as a reviewer. Assignments and review requests are still not in my muscle memory for GitHub 😇

@lgeiger lgeiger requested a review from jamescook106 July 2, 2019 10:24
@jamescook106 jamescook106 merged commit e717ada into master Jul 2, 2019
@jamescook106 jamescook106 deleted the twitter branch July 2, 2019 10:28
@lgeiger lgeiger added this to the v0.4.0 milestone Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescook106 jamescook106 jamescook106 approved these changes

Assignees
No one assigned
Labels
documentation Issues related to missing or wrong documentation
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lgeiger @jamescook106