Made compatible with Zookeeper >= 0.5 #62
Conversation
setup.py
Outdated
| @@ -8,7 +8,7 @@ def readme(): | |||
|
|
|||
| setup( | |||
| name="larq-zoo", | |||
| version="0.3.0", | |||
| version="0.4.0", | |||
There was a problem hiding this comment.
I am not sure if this is right. Since this is breaking (in that the new zookeeper version is incompatible with the old one) I assume we go from 0.3.0 to 0.4.0.
There was a problem hiding this comment.
It looks like so far each release had either some new model or improved weights of already existing models in it. For my feeling this is more a 0.3.1 but I am also a bit uncertain about this.
There was a problem hiding this comment.
@koenhelwegen could you shine some light here?
There was a problem hiding this comment.
There is no need to change the version number when you change the code - it's fine if the master branch is non-compatible with the latest release. Releases are used to make a specific version of the code easily available (e.g. after a bug fix or when several changes are made). This is done by going to releases and drafting a release. When the time is there, we make a one line PR to change the version number (example).
Once we make the release I think we may want to go to 0.4 as it's a breaking change, but below 1.0.0 there are no real rules in general as far as I know.
There was a problem hiding this comment.
Correct. There is no need to change the version number here.
| @@ -17,7 +17,7 @@ def readme(): | |||
| url="https://github.com/plumerai/larq-zoo", | |||
| packages=find_packages(), | |||
| license="Apache 2.0", | |||
| install_requires=["numpy~=1.15", "larq~=0.5", "zookeeper>=0.3.1,<0.5.0"], | |||
| install_requires=["numpy~=1.15", "larq~=0.5", "zookeeper~=0.5"], | |||
There was a problem hiding this comment.
Doesn't it require zookeeper 0.5? If so I would use >=0.5.
There was a problem hiding this comment.
It does, I have implemented your fix in 7919417
There was a problem hiding this comment.
We should keep the dependency fixed to zookeeper~=0.5 to prevent us from accidentally pulling in breaking changes.
For reference ~=0.5 is equivalent to >=0.5.0,<0.6.0
timdebruin
force-pushed
the
general-preprocessing
branch
from
7919417
to
d529090
Compare
This fixes #57 closes #55