Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using open_excel("inexisting file") yields ununderstandble error #265

Closed
gdementen opened this issue May 17, 2017 · 0 comments
Closed

using open_excel("inexisting file") yields ununderstandble error #265

gdementen opened this issue May 17, 2017 · 0 comments
Labels
bug component: excel priority: high
Milestone
0.23

Comments

@gdementen
Copy link
Contributor

The problem is that:

wb = open_excel("inexisting_file.xlsx")

does NOT fail, but rather creates a new blank workbook, and then:

toto = wb['my_sheet']

fails. That error is not understandable either, but I will open another issue for this.

The solution to the first problem is to add an argument to open_excel and only create a new workbook if explicitly asked for.
alixdamman added a commit to alixdamman/larray that referenced this issue May 22, 2017
@alixdamman
fix larray-project#265 : added flag argument new_file to open_excel…
124e443 
… function + return an error if non existing Excel file and `new_file` not set to True.
alixdamman added a commit to alixdamman/larray that referenced this issue May 23, 2017
@alixdamman
fix larray-project#265 : return an error if non existing Excel file a…
3b27765 
…nd `overwrite_file` set to False when creating a Workbook instance.

+ updated docstring of open_excel
alixdamman added a commit to alixdamman/larray that referenced this issue May 23, 2017
@alixdamman
fix larray-project#265 : replaced overwrite_file by mode argument and…
d5023a3 
… return an error if non existing Excel file and mode is set to 'r' or 'r+'.

+ available modes are 'r', 'w', 'a' and 'r+'.
+ updated docstring of open_excel.
alixdamman added a commit to alixdamman/larray that referenced this issue May 24, 2017
@alixdamman
fix larray-project#265 : replaced overwrite_file by mode argument and…
7e2185d 
… return an error if non existing Excel file and mode is set to 'r' or 'r+'.

+ available modes are 'r', 'w', 'a' and 'r+'.
+ updated docstring of open_excel.

(cherry picked from commit d5023a3)
alixdamman added a commit to alixdamman/larray that referenced this issue May 24, 2017
@alixdamman
fix larray-project#265 : open_excel and Worbook.init return an error …
57a38e2 
…if filepath represents a non existing Excel file and overwrite_file=False.

+ available modes are 'r', 'w', 'a' and 'r+'.
+ updated docstring of open_excel.
alixdamman added a commit to alixdamman/larray that referenced this issue May 24, 2017
@alixdamman
fix larray-project#265 : open_excel and Worbook.init return an error …
26f6b49 
…if filepath represents a non existing Excel file and overwrite_file=False.

+ available modes are 'r', 'w', 'a' and 'r+'.
+ updated docstring of open_excel.
@gdementen gdementen modified the milestone: 0.23 May 30, 2017
alixdamman added a commit to alixdamman/larray that referenced this issue Sep 6, 2017
@alixdamman
fix larray-project#265 : replaced overwrite_file by mode argument and…
47bdc9f 
… return an error if non existing Excel file and mode is set to 'r' or 'r+'.

+ available modes are 'r', 'w', 'a' and 'r+'.
+ updated docstring of open_excel.

(cherry picked from commit d5023a3)
gdementen pushed a commit that referenced this issue Aug 31, 2018
@alixdamman @gdementen
fix #265 : open_excel and Worbook.init return an error if filepath re…
485e223 
…presents a non existing Excel file and overwrite_file=False.

+ available modes are 'r', 'w', 'a' and 'r+'.
+ updated docstring of open_excel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component: excel priority: high
Projects
None yet
Milestone
0.23
Development

No branches or pull requests
2 participants
@gdementen @alixdamman