Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow passing explicit array/session names in compare #307

Closed
gdementen opened this issue Jun 9, 2017 · 2 comments
Closed

allow passing explicit array/session names in compare #307

gdementen opened this issue Jun 9, 2017 · 2 comments
Assignees
@gdementen
Labels
component: viewer enhancement
Milestone
0.24

Comments

@gdementen
Copy link
Contributor

No description provided.

@gdementen gdementen self-assigned this Jun 9, 2017
@alixdamman
Copy link
Collaborator

Why not adding special attribute name to LArray (as title) ?

@gdementen
Copy link
Contributor Author

because that would be tedious to set manually for all arrays, especially for those which are created using aggregates or binary ops. It might be interesting to have anyway but we certainly cannot rely on it to be set.

gdementen added a commit to gdementen/larray that referenced this issue Jun 9, 2017
@gdementen
* fixed autodetection of names in compare() and allowed to provide ex…
fe0e060 
…plict ones (fixes larray-project#306 and closes larray-project#307).

* added docstring for compare
gdementen added a commit to gdementen/larray that referenced this issue Jun 9, 2017
@gdementen
* fixed autodetection of names in compare() and allowed to provide ex…
5097330 
…plict ones (fixes larray-project#306 and closes larray-project#307).

* added docstring for compare
@gdementen gdementen modified the milestone: 0.24 Jun 14, 2017
gdementen added a commit that referenced this issue Aug 31, 2018
@gdementen
* fixed autodetection of names in compare() and allowed to provide ex…
8d24c41 
…plict ones (fixes #306 and closes #307).

* added docstring for compare
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdementen gdementen

Labels
component: viewer enhancement
Projects
None yet
Milestone
0.24
Development

No branches or pull requests
2 participants
@gdementen @alixdamman