New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
na, sort_columns, sort_rows silently ignored in read_excel #393
Comments
Ideally we should implement them (by passing the arguments down all the way to df_aslarray), but raising an explicit error would already be better than the current situation. |
Here is a test case whenever we want to implement the na argument for xlwings: >>> arr = ndtest((2, 2, 2), dtype=float)
>>> arr['a1', 'b0'] = np.nan
>>> arr
a b\c c0 c1
a0 b0 0.0 1.0
a0 b1 2.0 3.0
a1 b0 nan nan
a1 b1 6.0 7.0
>>> arr.to_frame(dropna='any', fold_last_axis_name=True).to_excel('test.xlsx', merge_cells=False)
>>> read_excel('test.xlsx', na=42)
a b\c c0 c1
a0 b0 0.0 1.0
a0 b1 2.0 3.0
a1 b0 nan nan
a1 b1 6.0 7.0
>>> read_excel('test.xlsx', na=42, engine='xlrd')
a b\c c0 c1
a0 b0 0 1
a0 b1 2 3
a1 b0 42 42
a1 b1 6 7 |
xlwings includes a Pandas Converter and allows to define UDF (user defined function). Shouldn't we use them? |
alixdamman
added a commit
to alixdamman/larray
that referenced
this issue
Sep 19, 2017
…lumns and sort_rows from read_excel in case engine=xlwings
alixdamman
added a commit
to alixdamman/larray
that referenced
this issue
Sep 19, 2017
…lumns and sort_rows from read_excel in case engine=xlwings
alixdamman
added a commit
to alixdamman/larray
that referenced
this issue
Sep 19, 2017
…lumns and sort_rows from read_excel in case engine=xlwings
alixdamman
added a commit
to alixdamman/larray
that referenced
this issue
Sep 20, 2017
…lumns and sort_rows from read_excel in case engine=xlwings
gdementen
pushed a commit
that referenced
this issue
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using xlwings backend, which is the default
The text was updated successfully, but these errors were encountered: