Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename to_excel sheet_name to sheet #580

Closed
gdementen opened this issue Feb 15, 2018 · 6 comments
Closed

rename to_excel sheet_name to sheet #580

gdementen opened this issue Feb 15, 2018 · 6 comments
Labels
component: excel difficulty: low enhancement syntax
Milestone
0.28

Comments

@gdementen
Copy link
Contributor

since sheet_name can also be a sheet index, sheet seems more appropriate than sheet_name.
@gdementen gdementen mentioned this issue Feb 15, 2018
Open
@Avasse
Copy link

Avasse commented Feb 16, 2018

Hi, i'd be glad to work on this issue, is anybody working on it ?

@alixdamman
Copy link
Collaborator

@gdementen any objections?

@Avasse
Copy link

Avasse commented Feb 16, 2018 •
edited

@alixdamman @gdementen I already read the "How to contribute" http://larray.readthedocs.io/en/stable/contribute.html#sending-your-changes"

And did some changes to fit that issue. (See : #583) As it is my first PR, tell me if i did anything wrong please. Thanks you !

@gdementen
Copy link
Contributor Author

@alixdamman no, but that assumes you agree with the change...

@alixdamman
Copy link
Collaborator

@gdementen @Avasse I agree with the change.

@alixdamman alixdamman added this to the 0.28 milestone Feb 16, 2018
@gdementen gdementen changed the title rename to_excel sheet_name to sheet? rename to_excel sheet_name to sheet Feb 16, 2018
@alixdamman alixdamman mentioned this issue Feb 16, 2018
Closed
Avasse pushed a commit to Avasse/larray that referenced this issue Feb 23, 2018
fix(larray-project#580): Renamed sheetname to sheet in to_excel
bae63e6
gdementen pushed a commit that referenced this issue Feb 23, 2018
@gdementen
fix(#580): Renamed sheetname to sheet in to_excel
de449aa
@gdementen
Copy link
Contributor Author

closed by de449aa

gdementen pushed a commit that referenced this issue Aug 31, 2018
@gdementen
fix(#580): Renamed sheetname to sheet in to_excel
b30545e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: excel difficulty: low enhancement syntax
Projects
None yet
Milestone
0.28
Development

No branches or pull requests
3 participants
@gdementen @Avasse @alixdamman