Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug when writing metadata #702

Closed
alixdamman opened this issue Oct 1, 2018 · 4 comments
Closed

bug when writing metadata #702

alixdamman opened this issue Oct 1, 2018 · 4 comments
Assignees
@alixdamman
Labels
bug priority: high
Milestone
0.30

Comments

@alixdamman
Copy link
Collaborator

fix is:

def _dump_metadata(self, metadata):
    root = self.handle._handle.root
    root._v_attrs.metadata = metadata
@alixdamman alixdamman added the bug label Oct 1, 2018
@alixdamman alixdamman added this to the 0.30 milestone Oct 1, 2018
@gdementen
Copy link
Contributor

or...

def _dump_metadata(self, metadata):
    self.handle.root._v_attrs.metadata = metadata

@alixdamman alixdamman self-assigned this Nov 20, 2018
alixdamman added a commit to alixdamman/larray that referenced this issue Feb 4, 2019
@alixdamman
fix larray-project#702 : fixed bug when writing metadata using HDF fo…
9caa3d4 
…rmat
@alixdamman
Copy link
Collaborator Author

Note: problem occurs for pandas < 0.18.0

@gdementen
Copy link
Contributor

I guess adding a requirement for pandas >= 0.18 seems reasonable

@alixdamman
Copy link
Collaborator Author

alixdamman commented Feb 5, 2019 •
edited

It's actually worse than that. See PR #740

alixdamman added a commit to alixdamman/larray that referenced this issue May 9, 2019
@alixdamman
fix larray-project#702 : fixed bug when writing metadata using HDF fo…
8a0a046 
…rmat
alixdamman added a commit to alixdamman/larray that referenced this issue May 10, 2019
@alixdamman
fix larray-project#702 : fixed bug when writing metadata using HDF fo…
01669f2 
…rmat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alixdamman alixdamman

Labels
bug priority: high
Projects
None yet
Milestone
0.30
Development

No branches or pull requests
2 participants
@gdementen @alixdamman