Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using your TAP reporter, test exits with code 0 even if there is a test case failure #174

Open
ORESoftware opened this issue Sep 7, 2017 · 5 comments

Comments

@ORESoftware
Copy link

Please see this issue I filed with Protractor.
I am not sure if the problem is a result of your library or Protractor.

angular/protractor#4479

@ORESoftware
Copy link
Author

I still have this issue, I even forgot I filed this already

angular/protractor#4575

@alecmerdler
Copy link
Contributor

I am seeing this issue as well. I have tried to compare it to the included Jasmine console reporter, but I don't see any differences that stand out as to why the exit code isn't being set.

@alecmerdler
Copy link
Contributor

My solution is to not call jasmine.getEnv().clearReporters(), which will keep the default dot reporter. This correctly sets the error code. I silence the output of the dot reporter using require('protractor/built/logger').Logger.setWrite(3), which sets the output to None.

@ORESoftware
Copy link
Author

ahhh, seems like a design flaw, but that might work, will try it thx

@zodiac1111
Copy link

I am not call jasmine.getEnv().clearReporters() too.

I found this :

jasmineNodeOpts: {
   ...
   print: function() {}
}

ref:Remove protractor dot reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants