This repository has been archived by the owner on Sep 29, 2022. It is now read-only.
React 0.14 upgrade #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fbjs to deps, since that's where the EventListener function moved to with React 0.14.
Require ReactDOM for tests.
Update example app to react 0.14. Generate new dist build.
The major error in the example app was that two versions of react was used at the same time. This was because web pack used both react from react-mini-router and example repository, which resulted in two react modules in public/js/app.js
|
Fantastic. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors in example app and use babel for JSX transformations in example app.