Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdMob ad creeps up screen on refresh #7

Closed
nepalibabu opened this issue Jul 24, 2012 · 20 comments
Closed

AdMob ad creeps up screen on refresh #7

nepalibabu opened this issue Jul 24, 2012 · 20 comments
Labels

Comments

@nepalibabu
Copy link

the admob ad keep moving up on the screen need to fix it don't know why???

@larsacus
Copy link
Owner

If you could post the code you're using to integrate it, and any other relevant code, it would help a ton.

@nepalibabu
Copy link
Author

  • (void)viewWillAppear:(BOOL)animated{
    [[LARSAdController sharedManager] addAdContainerToView:self.view withParentViewController:self];
    [[LARSAdController sharedManager] setShouldHandleOrientationChanges:YES];
    }

This is the code i am using do i have to make the view flexible to use the code?

@larsacus
Copy link
Owner

Are you making a call to [super viewWillAppear]? I don't think this
alone would cause it, but you still always need to call super's
implementation. Do you have any other animation code in your view
controller?

@nepalibabu
Copy link
Author

ya i am calling [Super ViewWIllAppear] still causing the problem

@nepalibabu
Copy link
Author

NO i don't

@larsacus
Copy link
Owner

Do you have any other relevent code to post? Do you have anything else in your view hierarchy or is it just the ad? Does it only move up the screen on one view, or does it do it on all views in your app?

@nepalibabu
Copy link
Author

no i dont have anything else just the ad and it happens in every view if iad is available it goes to bottom else it keep moving upwards...

@jcesarmobile
Copy link

happens the same to me, I have the basic code.
I think the ad moves up when it's refreshed, so I changed admob configuration (in the web) to refresh every 120s (the maximun time)

I can't give you more details because on my devices the iad test ad appears everytime, I just have seen the admob ad moving in friends mobiles.

@larsacus
Copy link
Owner

Changing the ad refresh time is really not ideal, seeing as this directly affects your ad revenue... I'm updating the primary project this lives in, so I'll be digging into this a little more, even though I haven't seen this issue firsthand.

Does it ever happen in the example project included with the source? A sample project that demonstrates the issue would really help.

larsacus added a commit that referenced this issue Aug 30, 2012
@larsacus
Copy link
Owner

Check out the last commit on the creeping-ads branch to see if this resolves the issue. (9605f0a)

@salmanlodhi
Copy link

Please tell me if its resolved or not.

Since my app went live on app store today and its showing same bugs where add keeps moving up after every refresh rate.

@larsacus
Copy link
Owner

Nobody has responded to say whether this has fixed the issue or not. I am not seeing the issue here on any my projects with the new code.

@jcesarmobile
Copy link

I can't test because I only get iAd ads, sorry.
Is there any way to force iAd to fail and then display admob?

@larsacus
Copy link
Owner

unfortunately, no. iAds kind of do whatever they please...

@salmanlodhi
Copy link

hmmm ...I am getting this error with admob ...... because iAd is not in country where I live ..... as a hint I can tell that on each refresh the ad appears on top of previous ad and below ad vanishes.... so its always one step above previous ad location.... I used your code copy in my projects around 30 days back..and you made changes after that ..... let me incorporate new code and then see

@salmanlodhi
Copy link

even when i test my code.... i get live ads from admob..... and the ad keeps creeping......now as soon as test ads from iAD comes..... then ad banner comes to its original place ....

@larsacus
Copy link
Owner

are you using the creeping-ads branch?

@salmanlodhi
Copy link

I just copied the new code now for LARSadcontroller.m file only........ and tested with this new one..... ad has stopped creeping...... plz let me know if this change is enough

I have sent update to apple right now ... lets see when it goes live then I would update

@salmanlodhi
Copy link

Hey,
Your last update is working fine now .

Cheers.

@larsacus
Copy link
Owner

I haven't heard anything saying it doesn't fix the issue, so I'm going to go ahead and close this issue, migrate the change to master and push a new version to cocoapods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants