Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegExp performance #107

Closed
larsgw opened this issue Dec 21, 2017 · 1 comment
Closed

RegExp performance #107

larsgw opened this issue Dec 21, 2017 · 1 comment
Projects
Version 0.4

Comments

@larsgw
Copy link
Owner

larsgw commented Dec 21, 2017 •
edited

Citation.js relies pretty heavily on RegExp (for now at least) and Babel, so this might be a it of an issue. Luckily, there's a workaround: most behaviour that uses RegExp is input parsing, which is now exchangeable with custom parsers.
@larsgw larsgw added this to General issues in Version 0.4 Jan 8, 2018
@larsgw
Copy link
Owner Author

larsgw commented May 8, 2018

Also, REDOS.

larsgw added a commit that referenced this issue May 11, 2018
@larsgw
[package:lint] Add REDOS linting
541f0dd 
See #107
larsgw added a commit that referenced this issue May 11, 2018
@larsgw
[input] Fix flagged REDOS regexes
b3266c3 
Fix some of the regexes flagged by the eslint
REDOS plugin.

See #107
larsgw added a commit that referenced this issue May 11, 2018
@larsgw
[output] Fix flagged REDOS regex
fa7cb32 
Fix some of the regexes flagged by the eslint
REDOS plugin.

See #107
larsgw added a commit that referenced this issue May 11, 2018
@larsgw
[package] Add REDOS tests and fix flagged regexes
7c52bef 
Since Citation.js uses quite a few of regexes,
from input validation, to parsing, to editting
HTML right before outputting (sorry). These can
be vulnerable to exponential backtracking,
possibly leading to REDOS (Regular Expression
Denial Of Service) issues, as kindly reported by
James Davis (@davisjam).

This commits adds tests to checks regexes for
backtracking vulnerabilities. It also 'fixes' all
regexes flagged by these tests. Note that with
these changes, some checks are less strict.
However, this shouldn't cause problems, as false
positives are still rare.

If any problems do occur, please report at
https://github.com/larsgw/citation.js/issues

See #107
@larsgw larsgw closed this as completed May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Version 0.4
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@larsgw