Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename constants #2101

Merged
merged 1 commit into from
Nov 17, 2018
Merged

rename constants #2101

merged 1 commit into from
Nov 17, 2018

Conversation

larshp
Copy link
Member

@larshp larshp commented Nov 15, 2018

local constant activity_delete_06 renamed to lc_activity_delete_06 in 2 classes

other changes are SE80 reorganizing method sequence

@fabianlupa
Copy link
Member

other changes are SE80 reorganizing method sequence

I wish there was a solution to prevent this :/

@larshp
Copy link
Member Author

larshp commented Nov 16, 2018

yeah, it is quite annoying, but after some time more classes will have the SE80 format

or the git diff should show per method instead of by file

@larshp
Copy link
Member Author

larshp commented Nov 17, 2018

SAP should fix SE80 so it preserves the method sequence 🤷‍♂️

@larshp larshp merged commit aac3c1b into master Nov 17, 2018
@larshp larshp deleted the naming branch November 17, 2018 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larshp @fabianlupa