Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: macros and exceptions #11

Merged
merged 30 commits into from
Jun 13, 2021
Merged

Refactoring: macros and exceptions #11

merged 30 commits into from
Jun 13, 2021

Conversation

kvtorp
Copy link
Contributor

@kvtorp kvtorp commented Jun 10, 2021

General rewrite and refactoring of the ZCL_MD4 class.

Kasper Torp and others added 30 commits June 10, 2021 07:49
If the data for the MD4 hash is passed in in the form of a fixed length character field, trailing whitespace was not ignored.
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Increased ABAP version to allow the NEW operator for creating new objects.
Disabled the final class check, as it disallowed a local test class to inherit from another local class (for testing protected members)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Removed macros
Made proper table literals
Moved table literals to class constructor
Removed large CASE-WHENs
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
My version of SE80 only allows form-based editing of global class-based exceptions. So it is impossible to remove the description mentioned by ABAPlint
This was referenced Jun 11, 2021
@larshp larshp changed the title Refactored ZCL_MD4 to avoid macros Refactoring: macros and exceptions Jun 13, 2021
@larshp
Copy link
Owner

larshp commented Jun 13, 2021

thanks 👍

@larshp larshp merged commit f981057 into larshp:main Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants