misc fixes (#741)

* 72, fix false positive for deleted tables * 83, fix false positive for deleted tables * 69, additional skips for idoc fm
larshp · Jul 26, 2019 · ce725eb · ce725eb
1 parent 4cf7cd7
commit ce725eb
Show file tree

Hide file tree

Showing 5 changed files with 56 additions and 3 deletions.
diff --git a/src/checks/zcl_aoc_check_69.clas.abap b/src/checks/zcl_aoc_check_69.clas.abap
@@ -1427,6 +1427,31 @@ CLASS ZCL_AOC_CHECK_69 IMPLEMENTATION.
 
     ENDIF.
 
+* idoc port function module, txn WE21 -> ABAP-PI
+    IF ms_naming-set_port = abap_true
+        AND rv_skip = abap_false.
+
+      CLEAR ls_check.
+      _append import 'I_WAIT'.
+      _append tables 'I_EDIDC'.
+
+      rv_skip = skip_fm_parameters_check( is_parameters = is_parameters
+                                          is_check      = ls_check ).
+
+    ENDIF.
+
+* idoc master idoc distribution, TBDME-IDOCFBNAME
+    IF ms_naming-set_port = abap_true
+        AND rv_skip = abap_false.
+
+      CLEAR ls_check.
+      _append import 'MESSAGE_TYPE'.
+
+      rv_skip = skip_fm_parameters_check( is_parameters = is_parameters
+                                          is_check      = ls_check ).
+
+    ENDIF.
+
   ENDMETHOD.
 
 

diff --git a/src/checks/zcl_aoc_check_72.clas.abap b/src/checks/zcl_aoc_check_72.clas.abap
@@ -84,7 +84,7 @@ CLASS ZCL_AOC_CHECK_72 IMPLEMENTATION.
       EXCEPTIONS
         access_failure = 1
         OTHERS         = 2.
-    IF sy-subrc <> 0.
+    IF sy-subrc <> 0 OR ls_dd02v IS INITIAL.
       RETURN.
     ENDIF.
 

diff --git a/src/checks/zcl_aoc_check_83.clas.abap b/src/checks/zcl_aoc_check_83.clas.abap
@@ -83,7 +83,7 @@ CLASS ZCL_AOC_CHECK_83 IMPLEMENTATION.
         ENDIF.
       WHEN 'TABL'.
         SELECT SINGLE * FROM dd02l INTO ls_dd02l WHERE tabname = object_name. "#EC CI_NOORDER
-        IF sy-subrc = 0 AND ls_dd02l-tabclass = 'APPEND'.
+        IF ( sy-subrc = 0 AND ls_dd02l-tabclass = 'APPEND' ) OR sy-subrc <> 0.
           RETURN.
         ENDIF.
         SELECT SINGLE * FROM dd40l INTO ls_dd40l WHERE rowtype = object_name.

diff --git a/src/ui/zaoc_naming.fugr.lzaoc_namingtop.abap b/src/ui/zaoc_naming.fugr.lzaoc_namingtop.abap
@@ -128,7 +128,9 @@ SELECTION-SCREEN BEGIN OF BLOCK fmsig WITH FRAME TITLE TEXT-fsi.
 PARAMETERS: p_cfunc  TYPE c AS CHECKBOX MODIF ID ro,
             p_idocfm TYPE c AS CHECKBOX MODIF ID ro,
             p_bwext  TYPE c AS CHECKBOX MODIF ID ro,
-            p_shlp   TYPE c AS CHECKBOX MODIF ID ro.
+            p_shlp   TYPE c AS CHECKBOX MODIF ID ro,
+            p_port   TYPE c AS CHECKBOX MODIF ID ro,
+            p_masi   TYPE c AS CHECKBOX MODIF ID ro.
 SELECTION-SCREEN END OF BLOCK fmsig.
 SELECTION-SCREEN BEGIN OF BLOCK mmsig WITH FRAME TITLE TEXT-msi.
 PARAMETERS: p_pmeth TYPE c AS CHECKBOX MODIF ID ro.

diff --git a/src/ui/zaoc_naming_settings.tabl.xml b/src/ui/zaoc_naming_settings.tabl.xml
@@ -137,6 +137,32 @@
      <MASK>  CHAR</MASK>
      <DDTEXT>Search help exits</DDTEXT>
     </DD03P>
+    <DD03P>
+     <TABNAME>ZAOC_NAMING_SETTINGS</TABNAME>
+     <FIELDNAME>SET_PORT</FIELDNAME>
+     <DDLANGUAGE>E</DDLANGUAGE>
+     <POSITION>0011</POSITION>
+     <ADMINFIELD>0</ADMINFIELD>
+     <INTTYPE>C</INTTYPE>
+     <INTLEN>000002</INTLEN>
+     <DATATYPE>CHAR</DATATYPE>
+     <LENG>000001</LENG>
+     <MASK>  CHAR</MASK>
+     <DDTEXT>iDoc port function module</DDTEXT>
+    </DD03P>
+    <DD03P>
+     <TABNAME>ZAOC_NAMING_SETTINGS</TABNAME>
+     <FIELDNAME>SET_MASI</FIELDNAME>
+     <DDLANGUAGE>E</DDLANGUAGE>
+     <POSITION>0012</POSITION>
+     <ADMINFIELD>0</ADMINFIELD>
+     <INTTYPE>C</INTTYPE>
+     <INTLEN>000002</INTLEN>
+     <DATATYPE>CHAR</DATATYPE>
+     <LENG>000001</LENG>
+     <MASK>  CHAR</MASK>
+     <DDTEXT>iDoc master idoc distribution</DDTEXT>
+    </DD03P>
    </DD03P_TABLE>
   </asx:values>
  </asx:abap>