make lua_obj optional

so that printing a function would not cause crash
laruence · May 24, 2019 · 13e26a3 · 13e26a3
1 parent ef70d19
commit 13e26a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/lua.c b/lua.c
@@ -355,11 +355,6 @@ zval *php_lua_get_zval_from_lua(lua_State *L, int index, zval *lua_obj, zval *rv
 		case LUA_TFUNCTION:
 			{
 				long ref_id = 0;
-				if (!lua_obj) {
-					php_error_docref(NULL, E_WARNING, "corrupted Lua object");
-					break;
-				}
-
 				lua_pushvalue(L, index);
 				ref_id = luaL_ref(L, LUA_REGISTRYINDEX);
 

diff --git a/lua_closure.c b/lua_closure.c
@@ -53,7 +53,9 @@ zval* php_lua_closure_instance(zval *instance, long ref_id, zval *lua_obj) {
 	object_init_ex(instance, lua_closure_ce);
 	objval = php_lua_closure_object_from_zend_object(Z_OBJ_P(instance));
 	objval->closure = ref_id;
-	ZVAL_ZVAL(&(objval->lua), lua_obj, 1, 0);
+	if (lua_obj) {
+		ZVAL_ZVAL(&(objval->lua), lua_obj, 1, 0);
+	}
 
 	return instance;
 }