Adopted trait registration API and fixed iOS 17 crash #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lascic
approved these changes
Sep 10, 2023
|
Great! Could you please merge this PR and create a new release? The Xcode 15 Release Candidate should be available in a few days, and many devs will submit their iOS 17 updates to the App Store shortly after. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #15
iOS 17 calls
traitCollectionDidChange(_:)earlier in the lifecycle when the view properties are not yet initialized. This causes a crash which can be avoided by checking if the view is already visible.This PR also adopts the new trait registration API in iOS 17: https://developer.apple.com/videos/play/wwdc2023-10057/?time=1196
Note: I've added another commit to restore compatibility with Xcode 14 because the symbols
UITraitHorizontalSizeClassandregisterForTraitChangesare not available in this version.